Re: [PATCH V3] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Wed Aug 05 2015 - 14:50:25 EST


On Mon, Aug 03, 2015 at 08:26:40AM +0000, Wang, Biao wrote:
> Consider the following case:
> Task A trigger lmk with a lock held, while task B try to get this lock, but unfortunately B is the very culprit task lmk select to kill. Then B will never be killed, and A will forever select B to kill.
> Such dead lock will trigger softlock up issue.
>
> This patch try to pick the next task to break this loop.
>
> Signed-off-by: Wang Biao <biao.wang@xxxxxxxxx>
> Reviewed-by: Zhang Di <di.zhang@xxxxxxxxx>
> ---
> drivers/staging/android/lowmemorykiller.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Please address Dave's review comments, I'll not take this as-is, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/