Re: [PATCH 1/3] zpool: add zpool_has_pool()

From: Andrew Morton
Date: Wed Aug 05 2015 - 18:07:09 EST


On Wed, 5 Aug 2015 18:00:26 -0400 Dan Streetman <ddstreet@xxxxxxxx> wrote:

> >
> > If there's some reason why this can't happen, can we please have a code
> > comment which reveals that reason?
>
> zpool_create_pool() should work if this returns true, unless as you
> say the module is rmmod'ed *and* removed from the system - since
> zpool_create_pool() will call request_module() just as this function
> does. I can add a comment explaining that.

I like comments ;)

Seth, I'm planning on sitting on these patches until you've had a
chance to review them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/