Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

From: Andy Lutomirski
Date: Thu Aug 06 2015 - 11:30:34 EST


On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Aug 04, 2015 at 08:39:27PM +0000, Liang, Kan wrote:
> - default:
> - err = -ENOTSUPP;
> + if (!msr[i].test() || rdmsrl_safe(msr[i].msr, &val))
> + msr[i].attr = NULL;

IIRC rdmsrl_safe literally never fails under QEMU TCG, and I'm not
entirely sure what happens under KVM if emulation kicks in. It might
pay to keep the model check for the non-architectural stuff, or at
least check for a nonzero return value.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/