Re: [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel Sunrisepoint

[Wolfram Sang]

On Thu, Aug 06, 2015 at 01:00:24PM +0100, Matt Fleming wrote:
> (Sorry for the delay in replying)
> 
> On Fri, 31 Jul, at 11:41:04AM, Andy Shevchenko wrote:
> > >  
> > > +	if (val32 & enable_bit)
> > > +		ret = -EIO;
> > > +
> > >  	return ret; /* returns: 0 = OK, -EIO = Error */
> > 
> > What about removing ret at all?
> > 
> > if (val32 & enable_bit)
> >  return -EIO;
> > 
> > return 0;
>  
> Yeah, good catch. I'll make this change.

I'd go for the ternary operator here.

Attachment: signature.asc
Description: Digital signature