Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

[David Miller]

From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Thu, 6 Aug 2015 16:13:11 +0300

> On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote:
>> virtio declares support for NETIF_F_FRAGLIST, but assumes
>> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
>> always true with a fraglist.
>> 
>> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
>> the sg array, leading to memory corruption.
>> 
>> Drop NETIF_F_FRAGLIST so we only get what we can handle.
>> 
>> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
>> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
> 
> I noticed only now that this didn't Cc Dave, so of course it's
> not applied.

CC:'ing me isn't the requirement. CC:'ing netdev is, which he
did.  If you check patchwork, it's there in the queue.

I'm just behind and heavily backlogged because I've been working
on other things.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/