Re: [PATCH 11/31] cpufreq/sfi: use kmemdup rather than duplicating its implementation

From: Viresh Kumar
Date: Fri Aug 07 2015 - 04:59:12 EST


On 07-08-15, 09:59, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
> drivers/cpufreq/sfi-cpufreq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c
> index ffa3389..992ce6f 100644
> --- a/drivers/cpufreq/sfi-cpufreq.c
> +++ b/drivers/cpufreq/sfi-cpufreq.c
> @@ -45,12 +45,10 @@ static int sfi_parse_freq(struct sfi_table_header *table)
> pentry = (struct sfi_freq_table_entry *)sb->pentry;
> totallen = num_freq_table_entries * sizeof(*pentry);
>
> - sfi_cpufreq_array = kzalloc(totallen, GFP_KERNEL);
> + sfi_cpufreq_array = kmemdup(pentry, totallen, GFP_KERNEL);
> if (!sfi_cpufreq_array)
> return -ENOMEM;
>
> - memcpy(sfi_cpufreq_array, pentry, totallen);
> -

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/