Re: [PATCH v1 1/7] ARM: dts: ifc6410: Add pwrseq support for WLAN

[Srinivas Kandagatla]

On 29/07/15 23:55, Stephen Boyd wrote:
> On 07/28/2015 05:53 AM, Srinivas Kandagatla wrote:
> > +
> > +        sdcc4_pwrseq:pwrseq {
>
> Missing space here between label and node name.
I will fix this in next version.
> > +            compatible = "mmc-pwrseq-simple";
> > +            reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>;
> > +        };
> > +
>
> Also this node is not part of the SoC so it should be in the root,
> possibly under some sort of power-sequences node so that all the
> sequences are grouped in one place.
Good spot and suggestion. I will do that in next version.

--srini
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/