Re: [PATCH] regmap: Remove useless check

[Mark Brown]

On Fri, Aug 07, 2015 at 06:33:36PM +0100, Salah Triki wrote:
> lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the
> return value is useless.

No, if you want to do this then you should be fixing the LZO API to
remove the returned value - if a value is being returned it's always
good practice to pay attention to that, not doing that because the
current implementation happens to have some behaviour just makes the
code more fragile if someone comes along and changes the implementation.

Attachment: signature.asc
Description: Digital signature