Re: [v2 8/9] dpaa_eth: add debugfs entries

From: David Miller
Date: Fri Aug 07 2015 - 18:37:23 EST


From: Madalin Bucur <madalin.bucur@xxxxxxxxxxxxx>
Date: Wed, 5 Aug 2015 18:41:28 +0300

> Export per CPU counters through debugfs.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@xxxxxxxxxxxxx>

This is absolutely inappropriate.

You can export these just fine via ethtool statistics. There is zero reason
to add ugly debugfs crap for something like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/