Re: [PATCH] perf, tools, report: Add support for srcfile sort key
From: Namhyung Kim
Date: Sat Aug 08 2015 - 23:33:56 EST
On Sat, Aug 08, 2015 at 04:27:35AM +0200, Andi Kleen wrote:
> On Fri, Aug 07, 2015 at 09:02:15PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 07, 2015 at 08:51:45PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Aug 07, 2015 at 03:54:24PM -0700, Andi Kleen escreveu:
> > > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > >
> > > > In some cases it's useful to characterize samples by file. This is useful
> > > > to get a higher level categorization, for example to map cost to
> > > > subsystems.
> > > >
> > > > Add a srcfile sort key to perf report. It builds on top of the existing
> > > > srcline support.
> > >
> > > Applied
> > Humm, holding this up a bit, further testing showed some oddities,
> > fedora21, the width of the column is being limited to the lenght of the
> > header
> Yes I've seen that, I just use -w normally. It also happens with --sort
> srcline. The column sizing code could probably be somewhat smarter and
> always allow the last column to become as wide as needed. But that's
> something that should be done separately; I don't think it belongs
> into this patch.
Maybe something like this?