Re: [PATCH] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

[Dmitry Torokhov]

Hi Andrew,

On Fri, Aug 07, 2015 at 05:37:49PM -0700, Andrew Duggan wrote:
> +Optional Properties:
> +- syna,sensor-name: The string containing the name of the sensor.
> +- syna,attn-gpio: The GPIO number used to assert attention.
> +- syna,attn-polarity: The polarity of the attention GPIO.
> +- syna,level-triggered: Set to 1 if attention GPIO is level triggered, 0 if
> +			edge triggered.

We already have generic bindings for i2c devices interrupt line, along
with trigger type. We also have standard bindings for gpios, with the
polarity. Interrupts are also parsed by the I2C core. There is no need
to invent your own bindings.

> +- syna,poll-interval-ms: The interval in milliseconds to wait between reading
> +			interrupts when the driver is polling.
> +- syna,reset-delay-ms: The number of milliseconds to wait after resetting the
> +			device.
> +- syna,f01-*: Additional parameters specific to RMI4 function 1
> +		see Documentation/devicetree/bindings/input/rmi4/rmi_f01.txt.
> +- syna,f11-*: Additional parameters specific to RMI4 function 11
> +		see Documentation/devicetree/bindings/input/rmi4/rmi_f11.txt.

For function parameters I wonder if they should not be modelled as
subnodes with "reg" representing function number.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/