Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.

From: Alexander Holler
Date: Sun Aug 09 2015 - 06:45:58 EST


Am 09.08.2015 um 11:00 schrieb NeilBrown:
On Sat, 8 Aug 2015 12:18:55 +0530 Kishon Vijay Abraham I
<kishon@xxxxxx> wrote:



On Saturday 08 August 2015 11:23 AM, Alexander Holler wrote:
Hello,

this patch killed the musb-host functionality on my classic Beagleboard (rev
c4). Symptom was that it there was a message I don't remember and the attached
device didn't enumerate anymore (likely because of missing power, but I'm not
sure).

A simple revert has fixed it, I haven't looked further into the problem.

Neil Brown, how was this tested?


Well, I have a board with an OMAP3 connected to a twl4030 for USB and I
noted that it wasn't power-managed properly and when I made that change,
it was. I don't recall the exact details

This is probably related to

Commit: 56301df6bcaa ("phy: twl4030-usb: make runtime pm more reliable.")

I certainly only tested with that patch in place.

Cherry-Picking 56301df6bcaa instead of reverting d1221a608bd did the trick too. So it looks like 56301df6bcaa is indeed a prerequisit for d1221a608bd.

Therefor I suggest to feed 56301df6bcaa to the stable series (e.g. 4.1.6) too.

Regards,

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/