Re: [PATCH] Add space after ,

From: Larry Finger
Date: Sun Aug 09 2015 - 12:21:51 EST

On 08/09/2015 11:08 AM, Swee Hua Law wrote:
add space after , to fix coding style issue

Signed-off-by: Swee Hua Law <sweehua81@xxxxxxxxx>
drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
index 29a29d9..48b7723 100644
--- a/drivers/staging/rtl8723au/core/rtw_sreset.c
+++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
@@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
/* pairwise key */
rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
/* group key */
- rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
+ rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);

There are at least three problems with this patch. The first is that your subject is really awful. You need to say that you are fixing a checkpatch warning, and then say exactly what is happening. The second probalm also concerns the subject, which needs to specify what component is being changed. For drivers in staging, the usual way to do this is to start the subject line with "staging: rtl8723au: ...". The third problem is that you should fix *ALL* the problems with a given line whenever you touch it. That line is clearly over the 80-character limit.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at