Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect.

From: Richard Stearn
Date: Mon Aug 10 2015 - 08:01:25 EST


Ben Hutchings wrote:
3.2.71-rc1 review patch. If anyone has any objections, please let me know.

------------------

From: Richard Stearn <richard@xxxxxxxxxxxxxxxxxxxxxx>

commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream.

This may result in a kernel panic. The bug has always existed but
somehow we've run out of luck now and it bites.

Signed-off-by: Richard Stearn <richard@xxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
net/ax25/ax25_subr.c | 1 +
1 file changed, 1 insertion(+)

--- a/net/ax25/ax25_subr.c
+++ b/net/ax25/ax25_subr.c
@@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int
{
ax25_clear_queues(ax25);
+ ax25_stop_heartbeat(ax25);
ax25_stop_t1timer(ax25);
ax25_stop_t2timer(ax25);
ax25_stop_t3timer(ax25);

This patch should _not_ be applied.
Breaks other parts of the driver.
Investigations on-going.

--
Regards
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/