Re: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness aware read.
From: Noam Camus
Date: Mon Aug 10 2015 - 15:13:48 EST
From: Greg KH <greg@xxxxxxxxx>
Sent: Tuesday, August 4, 2015 2:42 AM
> > - reg = readl(p->membase + DW_UART_CPR);
> > + reg = (p->iotype == UPIO_MEM32BE) ?
> > + ioread32be(p->membase + DW_UART_CPR) :
> > + readl(p->membase + DW_UART_CPR);
> Same here.
> And shouldn't all of this be "hidden" behind something else? You should
not have to do this for each readl call...
As I wrote for last patch, I will add another level for accessors and use it here.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/