Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

[Darren Hart]

On Fri, Aug 07, 2015 at 08:48:18AM +0000, Chen, Yu C wrote:
> On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote:
> > On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote:					\
> > > +	ret;							\
> > > +})
> > 
> > This seems a bit complicated.
> > 
> > The else ret = 0 isn't necessary as it's initialized to 0.
> > bool might be better than int.
> > 
> Got.
> > > +static void surface_button_notify(struct acpi_device *device, u32 event)
> > > +{
> > > +	struct surface_button *button = acpi_driver_data(device);
> > > +	struct input_dev *input;
> > > +	int key_code = KEY_RESERVED;
> > > +	bool pressed = false;
> > > +
> > > +	if (!handle_surface_button_notify(POWER, KEY_POWER) &&
> > > +		!handle_surface_button_notify(HOME, KEY_LEFTMETA) &&
> > > +		!handle_surface_button_notify(VOLUME_UP, KEY_VOLUMEUP) &&
> > > +		!handle_surface_button_notify(VOLUME_DOWN, KEY_VOLUMEDOWN))
> > > +		dev_info_ratelimited(&device->dev,
> > > +			"Unsupported event [0x%x]\n", event);
> > 
> > Some might prefer alignment to the open parenthesis:
> > 
> > 	if (!handle_surface_button_notify(POWER, KEY_POWER) &&
> > 	    !handle_surface_button_notify(HOME, KEY_LEFTMETA) &&
> > 	    !handle_surface_button_notify(VOLUME_UP, KEY_VOLUMEUP) &&
> > 	    !handle_surface_button_notify(VOLUME_DOWN, KEY_VOLUMEDOWN))
> > 
> > I think the older switch/case was easier to understand.
> > 
> OK, then let's keep the switch/case.
> thanks.

Agreed.


-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/