Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

[Stephen Boyd]

On 08/11, Viresh Kumar wrote:
> On 10-08-15, 23:02, Stephen Boyd wrote:
> > > -	if (prop->length != sizeof(__be32)) {
> > > -		dev_err(dev, "%s: Invalid opp desc phandle\n", __func__);
> > > -		return ERR_PTR(-EINVAL);
> > > -	}
> > 
> > But we lost this check? Perhaps we can use
> > of_count_phandle_with_args() to make suer we only have one
> > phandle?
> 
> I thought about it earlier and it looked like we don't need to care
> about this. Even if the user passes multiple strings here, its his
> problem. We will just pick the first entry and parse it.
> 
> And that's true until the point we support multiple table entries,
> ofcourse :)

Ok. That's worth a mention in the commit text please.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/