Re: [RFC PATCH] mmc: sdhci-of-arasan: Add the support for sdhci-5.1

[Shawn Lin]

On 2015/8/11 13:06, Michal Simek wrote:
> On 08/11/2015 03:34 AM, Shawn Lin wrote:
> > This patch adds the quirks and compatible string in sdhci-of-arasan.c
> > to support sdhci-arasan5.1 version of controller. No documented controller
> > IP version is found in the TRM, so we use ths version of command queueing
> > engine integrated into this controller by arasan to specify our controller.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> >
> > ---
> >
> >   Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
> >   drivers/mmc/host/sdhci-of-arasan.c                     | 4 ++++
> >   2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > index 7e94903..da541c3 100644
> > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
> >
> >   Required Properties:
> >     - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
> > -                'arasan,sdhci-4.9a'
> > +                'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
> >     - reg: From mmc bindings: Register location and length.
> >     - clocks: From clock bindings: Handles to clock inputs.
> >     - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
> > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> > index ef5a7d2..c9012f5 100644
> > --- a/drivers/mmc/host/sdhci-of-arasan.c
> > +++ b/drivers/mmc/host/sdhci-of-arasan.c
> > @@ -175,6 +175,9 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> >   	if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
> >   		host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> >   		host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > +	} else if (of_device_is_compatible(pdev->dev.of_node,
> > +					   "arasan,sdhci-5.1")) {
> > +		host->quirks |= SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN;
>
> Is this broken Arasan version or just broken capability on your SoC?

Hi Michal,
It's just the broken capability on my Soc. I have checked with my ASIC 
guy, "base clock frequency for SD clock" in my platform is initialized 
to 2h'00 to indicate driver should get it by reading system clock unit.

> Thanks,
> Michal


--
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/