Re: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix
From: Alexandre Belloni
Date: Tue Aug 11 2015 - 10:15:53 EST
On 11/08/2015 at 10:04:04 -0400, Paul Gortmaker wrote :
> We currently see this warning:
> drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err'
> introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos:
> Cancel alarm timer if alarm time is equal to now+1 seconds").
> Presumably some WIP version of the commit was doing error checking
> but then the variable was not removed prior to submission, and the
> pending commits weren't on kernel.org for kbuild bot to spot the new
> warning created.
> Cc: Adrian Huang <ahuang12@xxxxxxxxxx>
> Cc: Egbert Eich <eich@xxxxxxx>
> Cc: Diego Ercolani <diego.ercolani@xxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: rtc-linux@xxxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> [Note: patch is against linux-next, so if the rtc tree is rebased,
> then the above commit ID reference will be stale. Feel free to
> adjust the commit log appropriately, if need be, or even squash
> this into the original offending patch, if rebasing back that far.
> Also ensuring your tree is on kernel.org will allow kbuild bot
> to spot these on your behalf via the zero day builds.]
I'm pretty sure my rtc-next branch on kernel.org already carry the fix.
I fixed it on monday: 2015-08-10 07:12:44 (GMT). It just seems that
linux-next has not been updated since then.
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/