Re: [PATCH] m68k/coldfire: use PFN_DOWN macro

[Geert Uytterhoeven]

Hi Alexander,

On Tue, Aug 11, 2015 at 6:57 PM, Alexander Kuleshov
<kuleshovmail@xxxxxxxxx> wrote:
> Replace ((x) >> PAGE_SHIFT) with the predefined PFN_DOWN macro.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
> ---
>  arch/m68k/coldfire/m54xx.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m54xx.c b/arch/m68k/coldfire/m54xx.c
> index 075aaab..f7836c6 100644
> --- a/arch/m68k/coldfire/m54xx.c
> +++ b/arch/m68k/coldfire/m54xx.c
> @@ -25,4 +25,5 @@
>  #include <asm/m54xxgpt.h>
>  #ifdef CONFIG_MMU
>  #include <asm/mmu_context.h>
> +#include <linux/pfn.h>
>  #endif
>
>  /***************************************************************************/
> @@ -91,1 +92,1 @@ static void __init mcf54xx_bootmem_alloc(void)

The numbers in the above line don't make sense?

>         m68k_memory[0].size = _ramend - _rambase;
>
>         /* compute total pages in system */
> -       num_pages = (_ramend - _rambase) >> PAGE_SHIFT;
> +       num_pages = PFN_DOWN(_ramend - _rambase);
>
>         /* page numbers */
>         memstart = PAGE_ALIGN(_ramstart);
> -       min_low_pfn = _rambase >> PAGE_SHIFT;
> -       start_pfn = memstart >> PAGE_SHIFT;
> -       max_low_pfn = _ramend >> PAGE_SHIFT;
> +       min_low_pfn = PFN_DOWN(_rambase);
> +       start_pfn = PFN_DOWN(memstart);
> +       max_low_pfn = PFN_DOWN(_ramend);
>         high_memory = (void *)_ramend;
>
>         m68k_virt_to_node_shift = fls(_ramend - _rambase - 1) - 6;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/