Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

[Xie XiuQi]

On 2015/8/12 2:52, Luck, Tony wrote:
> > Well, ok, but do it differently, please: rename
> > cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
> > turns them on and off. Unless Tony has a better suggestion...
>
> I like the boolean argument ... but not the "switch_banks" name. It sounds more
> like we are juggling between banks, rather than setting a switch/flag in a bank.
>
> How does "cmci_storm_set_cmci(bool on)" sound?  Too many "cmci" in one name?

Thanks, I'll use this name.

--
Xie XiuQi

> -Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/