Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers

[Russell King - ARM Linux]

On Wed, Aug 12, 2015 at 08:01:32AM +0000, Wang Dongsheng wrote:
> Hi Russell,
> 
> Thanks for your review. :)
> 
> > -----Original Message-----
> > From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx]
> > Sent: Wednesday, August 12, 2015 3:45 PM
> > To: Wang Dongsheng-B40534
> > Cc: shawn.guo@xxxxxxxxxx; Wang Huan-B18965; linus.walleij@xxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; sandeep_n@xxxxxx; hdegoede@xxxxxxxxxx; linux-arm-
> > kernel@xxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers
> > 
> > On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote:
> > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new
> > > file mode 100644 index 0000000..863d1ef
> > > --- /dev/null
> > > +++ b/drivers/soc/fsl/Kconfig
> > > @@ -0,0 +1,18 @@
> > > +#
> > > +# Freescale SOC drivers
> > > +#
> > > +menuconfig FSL_SOC_DRIVERS
> > > +	bool "Freescale Soc Drivers"
> > > +	default n
> > 
> > No need for default n.
> 
> Thanks. Fix it in next version.
> 
> > > +	help
> > > +	Say y here to enable Freescale LS1021A Soc Device Drivers support.
> > > +	The Soc Drivers provides the device driver that is a specific block
> > > +	or feature on LS1021A platform.
> > 
> > Help text should be indented by two spaces as per almost every other help text.
> > 
> 
> Thanks. My mistake...
> 
> > > +
> > > +if LS1_SOC_DRIVERS
> > > +	source "drivers/soc/fsl/ls1/Kconfig"
> > > +endif
> > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile new
> > > file mode 100644 index 0000000..b4215dd
> > > --- /dev/null
> > > +++ b/drivers/soc/fsl/Makefile
> > > @@ -0,0 +1,6 @@
> > > +#
> > > +# Makefile for Freescale Soc specific device drivers.
> > > +#
> > > +
> > > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/
> > > +
> > > diff --git a/drivers/soc/fsl/ls1/Kconfig b/drivers/soc/fsl/ls1/Kconfig
> > > new file mode 100644 index 0000000..7556f44
> > > --- /dev/null
> > > +++ b/drivers/soc/fsl/ls1/Kconfig
> > > @@ -0,0 +1,3 @@
> > > +#
> > > +# LS-1 Soc drivers
> > > +#
> > 
> > Doesn't this directory need a Makefile as well?
> > 
> 
> 2/2 patch add a config option and Makefile for this.

If _just_ this patch is merged, it creates a build problem as
CONFIG_LS1_SOC_DRIVERS can be enabled, which will cause the kbuild to
decend into drivers/soc/fsl/ls1, where it will stop due to the missing
build error.

Please fix this by adding at least an empty Makefile to this directory.
Do not rely on patch 2 being merged to "fix" this.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/