Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl

[Pali RohÃr]

On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
> From: Yash Shah <yshah1@xxxxxxxxxxx>
> 
> Fix line over 80 characters warning as detected by checkpatch.pl
> 
> Signed-off-by: Yash Shah <yshah1@xxxxxxxxxxx>
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 8bc68e2..d36350e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>  
>  		tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
>  		tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
> -		tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
> +		tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
> +				 & 0xf0) >> 4;
>  		if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
>  			BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
>  			tmpbuf[i+2] |= 0x80;

Hi! I think that code after this change is less readable as before.

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/