Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect

From: Paolo Bonzini
Date: Wed Aug 12 2015 - 08:45:52 EST




On 11/08/2015 19:39, Nicholas Krause wrote:
> This fixes error handling in the function ioapic_write_indirect to
> properly check if the call to the function ioapoc_service service
> has failed by not returning the value zero to indicate success to
> check if this occurs when calling this particular function and if
> so return immediately to the caller of ioapic_write_indirect due
> to us no longer being able to continue the function
> ioapic_write_indirect after this call fails.

This is not true.

You are back to the older problem that you are not trying to understand
the functions you are modifying.


Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/