Re: [linux-sunxi] [PATCH v3 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

From: Hans de Goede
Date: Wed Aug 12 2015 - 10:49:19 EST


On 08/12/2015 03:29 PM, Michal Suchanek wrote:
The 250ms timeout is too short.

On my system enabling the oclk takes under 50ms and disabling slightly
over 100ms when idle. Under load disabling the clock can take over

This does not make mmc clock gating look like good option to have on
sunxi but the system should not crash with mmc clock gating enabled

This patch sets the timeout to 750ms.

Signed-off-by: Michal Suchanek <hramrach@xxxxxxxxx>

- remove debug message

Thanks, this one looks good to me:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Ulf, can you apply this one please?

Thanks & Regards,


- fix formatting
drivers/mmc/host/sunxi-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 4d3e1ff..a7b7a67 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -595,7 +595,7 @@ static irqreturn_t sunxi_mmc_handle_manual_stop(int irq, void *dev_id)

static int sunxi_mmc_oclk_onoff(struct sunxi_mmc_host *host, u32 oclk_en)
- unsigned long expire = jiffies + msecs_to_jiffies(250);
+ unsigned long expire = jiffies + msecs_to_jiffies(750);
u32 rval;

rval = mmc_readl(host, REG_CLKCR);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at