Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging
From: Igor Plyatov
Date: Thu Aug 13 2015 - 15:23:21 EST
Dear David and Joe,
thank you for patch review!
Please look at email with subject
"[PATCH v2] net: phy: workaround for buggy cable detection by LAN8700
after cable plugging"
Best wishes.
--
Igor Plyatov
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Thu, 13 Aug 2015 10:15:15 -0700
On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote:
On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote:
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in the
Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is
set, the ENERGYON bit does not asserted sometimes). This is a common bug of
LAN87xx family of PHY chips.
* The lan87xx_read_status() was improved to acquire ENERGYON bit. Its previous
algorythm still not reliable on 100 % and sometimes skip cable plugging.
[]
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
[]
@@ -104,10 +104,12 @@ static int lan911x_config_init(struct phy_device *phydev)
static int lan87xx_read_status(struct phy_device *phydev)
{
int err = genphy_read_status(phydev);
+ int rc;
Is there a reason to move this declaration?
There is no strict requirement to move declaration of the rc.
It was made just to have all declarations easily visible.
Generally it's better to have declarations
in the minimal/narrowest scope possible.
Agreed, and it's %100 unrelated to the purpose of this patch so not
should be included for that reason as well.
You will need to respin this patch with the variable moving elided.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/