Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

From: Andrey Shvetsov
Date: Fri Aug 14 2015 - 04:16:30 EST


On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
>
> Signed-off-by: Tomas Melin <tomas.melin@xxxxxx>
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@xxxxxx>
> ---
> drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c
> index 01b7489..a54cf2c 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.c
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c
> @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch,
> struct dim_ch_state_t *state_ptr)
> {
> if (!ch || !state_ptr)
> - return 0;
> + return NULL;
>
> state_ptr->ready = ch->state.level < 2;
> state_ptr->done_buffers = ch->done_sw_buffers_number;
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/