Re: [PATCHv6 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

From: Frans Klaver
Date: Fri Aug 14 2015 - 06:02:48 EST


On Fri, Aug 14, 2015 at 11:42 AM, Adrian Remonda
<adrianremonda@xxxxxxxxx> wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the offending 0 with NULL.
>
> Signed-off-by: Adrian Remonda <adrianremonda@xxxxxxxxx>
> ---
> v6: styling. Change the NULL test to comply with the Kernel coding style

Your commit message no longer fits the actual change...


> drivers/staging/most/mostcore/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
> index fa9c19b65a5c..7bb16db42893 100644
> --- a/drivers/staging/most/mostcore/core.c
> +++ b/drivers/staging/most/mostcore/core.c
> @@ -982,7 +982,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj,
> if (ret)
> return ret;
>
> - if (mdev_devnod == 0 || *mdev_devnod == 0) {
> + if (!mdev_devnod || *mdev_devnod == 0) {
> snprintf(devnod_buf, sizeof(devnod_buf), "%s-%s", mdev, mdev_ch);
> mdev_devnod = devnod_buf;
> }
> --

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/