Re: [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes()

From: Matt Fleming
Date: Fri Aug 14 2015 - 15:12:29 EST


On Fri, 14 Aug, at 11:55:27AM, Zhang, Jonathan Zhixiong wrote:
>
> >Also, this doesn't look like a small function - why is it inlined?
> The function grew a bit after its first version. Since it is on the
> fence of not being a small function, I did not change it to out of
> the line. I will move it to arch/arm64/kernel/acpi.c guarded by
> CONFIG_ACPI_APEI instead of having to create a very small new file,
> if there is no opposition.

Please keep Will in the loop (now Cc'd) since he originally suggested
moving this to a header file and marking it static inline.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/