Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

From: Mark Brown
Date: Fri Aug 14 2015 - 22:12:00 EST

On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote:

> vsel_reg and enable_reg of the pbias regulator descriptor should actually
> have the offset from syscon. However after the pbias device tree node

I'm having a hard time understanding this statement, sorry. What makes
you say that they "shouild actually have the offset from syscon"? What
is the problem that this is supposed to fix?

> is moved as a child node of syscon, vsel_reg and enable_reg has the
> absolute address because of the address translation that happens while
> creating device from device tree node.
> So avoid using platform_get_resource and use of_get_address in order to
> get only the offset (untranslated address) and populate these in
> vsel_reg and enable_reg.

This sounds like we're going in the wrong direction, we're moving from a
more generic API to a firmware specific one. Why is this a good fix?

Attachment: signature.asc
Description: Digital signature