Re: [PATCH] mm/memblock: validate the creation of debugfs files

From: Alexander Kuleshov
Date: Sat Aug 15 2015 - 03:27:04 EST


Hello Andrew,

On 08-14-15, Andrew Morton wrote:
> On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov <kuleshovmail@xxxxxxxxx> wrote:
>
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
>
> There's no changelog.

Yes, will add it if there will be sense in the patch.

>
> Why? Ignoring the debugfs API return values is standard practice.
>

Yes, but I saw many places where this practice is applicable (for example
in the kernel/kprobes and etc.), besides this, the memblock API is used
mostly at early stage, so we will have some output if something going wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/