Re: [PATCH] mm/memblock: validate the creation of debugfs files

[Alexander Kuleshov]

On 08-15-15, Andrew Morton wrote:
> Yes, I agree that if memblock's debugfs_create_file() fails, we want to
> know about it because something needs fixing.  But that's true of
> all(?) debugfs_create_file callsites, so it's a bit silly to add
> warnings to them all.  Why not put the warning into
> debugfs_create_file() itself?

Good idea, but there are already some debugfs_create_file calls with checks and
warning, if these checks failed. I don't know how many, but I saw it.
Double warning is not good too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/