Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Javier Martinez Canillas]

Hello Geert,

Thanks a lot for your feedback.

On Mon, Aug 17, 2015 at 9:56 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
> <javier.martinez@xxxxxxxxxxxxxxx> wrote:
>> The Chrome platform support depends on X86 || ARM because there are
>> only Chromebooks using those architectures. But only some drivers
>> depend on a given architecture, and the ones that do already have
>> a dependency on their specific Kconfig symbol entries.
>>
>> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
>> but is more future proof to remove the dependency and let the drivers
>> be built in all architectures if possible to have more build coverage.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>
> NAKed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> The proper way to have more build coverage is to extend the dependencies
> with "|| COMPILE_TEST".
>

Ok, I mentioned that as the other option but was not sure which one
was more suitable since CHROME_PLATFORMS is a category and the
individual drivers already depend on a given arch. But I will make it
depends on X86 || ARM again plus || COMPILE_TEST and in the future if
there is a Chromebook on !X86 and !ARM, that new arch can be added to
the or logic.

> Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a
> Kconfig warning on !X86 and !ARM.
>
> Mixing "select" and "depends" (all other ChromeOS stuff depends on the
> symbol) is bad practice, as it may lead to circular Kconfig dependencies.
>

Yes, I think this is the real issue. I added the select instead of a
depends to avoid breaking git bisection when moving the cros_ec com
helpers out of MFD since some platforms use MFD_CROS_EC but don't
enable CHROME_PLATFORMS on their defconfigs. But I'll change the
select to depends instead and include the defconfig changes as a
dependency in the series to avoid breaking git bisection.

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/