Re: [PATCH V2 1/2] arm64: apei: implement arch_apei_get_mem_attributes()
From: Matt Fleming
Date: Mon Aug 17 2015 - 09:06:03 EST
On Fri, 14 Aug, at 03:37:29PM, Jonathan (Zhixiong) Zhang wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@xxxxxxxxxxxxxx>
>
> Table 8 of UEFI 2.5 section 2.3.6.1 defines mappings from EFI
> memory types to MAIR attribute encodings for arm64.
>
> If the physical address has memory attributes defined by EFI
> memmap as EFI_MEMORY_[UC|WC|WT], return approprate page protection
> type according to the UEFI spec. Otherwise, return PAGE_KERNEL.
>
> Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> Acked-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@xxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Matt Fleming <matt.fleming@xxxxxxxxx>
> Cc: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> ---
> V2: Changed arm64's implementation of arch_apei_get_mem_attributes()
> from inline function to out of line function, based on Ingo's
> feedback.
>
> arch/arm64/include/asm/acpi.h | 5 +++++
> arch/arm64/kernel/acpi.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
Looks fine to me, though it appears to be missing Ard's Reviewed-by
tag (the only change from the previous version is that it's no longer
inline).
Reviewed-by: Matt Fleming <matt.fleming@xxxxxxxxx>
Ingo, are you going to pick up this patch series and apply it directly
to tip if you're OK with this version?
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/