Re: [PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER()
From: Dan Carpenter
Date: Mon Aug 17 2015 - 13:42:40 EST
On Mon, Aug 17, 2015 at 12:08:34PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
>
> Signed-off-by: Raphaël Beamonte <raphael.beamonte@xxxxxxxxx>
> ---
> + kfree(exported_g_tx_buf);
> + exported_g_tx_buf = NULL;
No need to add these new NULL assignments. The module is unloading so
no one cat re-use these pointers. Also as a process rule, you should
write down any behaviour changes in the changelog and why you think they
are needed.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/