Re: linux-next: Tree for Aug 17 (staging/hfi1)

From: Randy Dunlap
Date: Mon Aug 17 2015 - 18:36:08 EST


On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20150813:
>


Several items:

A: these and other similar errors:

In file included from ../drivers/staging/hfi1/chip.c:61:0:
../drivers/staging/hfi1/chip.c: In function ÃÂÂ__hfi1_trace_LINKVERBÃÂÂ:
../drivers/staging/hfi1/trace.h:1357:20: error: function ÃÂÂ__hfi1_trace_LINKVERBÃÂÂ can never be inlined because it uses variable argument lists
static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
^
../drivers/staging/hfi1/chip.c: In function ÃÂÂ__hfi1_trace_CNTRÃÂÂ:
../drivers/staging/hfi1/trace.h:1357:20: error: function ÃÂÂ__hfi1_trace_CNTRÃÂÂ can never be inlined because it uses variable argument lists
static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
^
../drivers/staging/hfi1/chip.c: In function ÃÂÂ__hfi1_trace_DC8051ÃÂÂ:
../drivers/staging/hfi1/trace.h:1357:20: error: function ÃÂÂ__hfi1_trace_DC8051ÃÂÂ can never be inlined because it uses variable argument lists
static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
^
../drivers/staging/hfi1/chip.c: In function ÃÂÂ__hfi1_trace_RCVCTRLÃÂÂ:
../drivers/staging/hfi1/trace.h:1357:20: error: function ÃÂÂ__hfi1_trace_RCVCTRLÃÂÂ can never be inlined because it uses variable argument lists
static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
^
../drivers/staging/hfi1/chip.c: In function ÃÂÂ__hfi1_trace_TIDÃÂÂ:
../drivers/staging/hfi1/trace.h:1357:20: error: function ÃÂÂ__hfi1_trace_TIDÃÂÂ can never be inlined because it uses variable argument lists
static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
^

B: When CONFIG_PCI is not enabled, lots of these errors:

In file included from ../drivers/staging/hfi1/chip.c:60:0:
../drivers/staging/hfi1/hfi.h:508:20: error: field ÃÂÂmsixÃÂÂ has incomplete type
struct msix_entry msix;
^

../drivers/staging/hfi1/chip.c: In function ÃÂÂdisable_intxÃÂÂ:
../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function ÃÂÂpci_intxÃÂÂ [-Werror=implicit-function-declaration]
pci_intx(pdev, 0);
^

so the driver should depend on PCI or maybe even PCI_MSI.

C. Please provide some contact info, e.g. in a TODO file or the MAINTAINERS file.


--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/