Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps()

[Jiang, Dave]

On Mon, 2015-08-17 at 17:31 -0500, Bjorn Helgaas wrote:
> On Wed, Jul 29, 2015 at 04:18:55PM -0600, Keith Busch wrote:
> > From: Dave Jiang <dave.jiang@xxxxxxxxx>
> > 
> > The setting of PCIe MPS should be left to the PCI subsystem and not
> > the driver. An ill configured MPS by the driver could cause the 
> > device
> > to not function or unstablize the entire system. Removing the 
> > exported
> > symbol.
> > 
> > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> > ---
> >  drivers/pci/pci.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 0008c95..92349ee 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -4121,7 +4121,6 @@ int pcie_set_mps(struct pci_dev *dev, int 
> > mps)
> >  	return pcie_capability_clear_and_set_word(dev, 
> > PCI_EXP_DEVCTL,
> >  						 
> >  PCI_EXP_DEVCTL_PAYLOAD, v);
> >  }
> > -EXPORT_SYMBOL(pcie_set_mps);
> 
> I think the pcie_set_mps() declaration could be moved from
> include/linux/pci.h to drivers/pci/pci.h, couldn't it?

Ok.