Re: [PATCH] ASoC: tegra: Convert to managed resources
From: Vaishali Thakkar
Date: Mon Aug 17 2015 - 22:45:57 EST
On Tue, Aug 18, 2015 at 2:17 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Mon, Aug 17, 2015 at 03:02:29PM +0530, Vaishali Thakkar wrote:
>
>> I think you are right. I missed that. But now thing is , this patch is already
>> applied here:
>> https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=topic/tegra
>
>> I am not sure if now I can change version 2 with the changes you suggested
>> or not. Although I will not be able to test it after changing 'goto
>> err_suspend'
>> as I don't have hardware but may be someone else can test it.
>
> You can send an incremental update on top of what's there, or it may be
> more sensible to just discard the change entirely. I suspect we're safe
> with either PM vs component ordering though since we should support !PM
> configurations anyway.
I think yes may be code was good before this. But devm_clk_put part should work
fine as call of it is before PM stuff. So, can I send a patch
reverting the change
of component part or do you want me to send a patch reverting whole change?
--
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/