Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

[Sudip Mukherjee]

On Tue, Aug 18, 2015 at 02:02:49AM -0400, Raphaël Beamonte wrote:
> 2015-08-18 1:44 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>:
> > I think that will be better, since you are sending the patch for
> > consistent spacing.
> 
> Actually, going through the bunch of patches, it seems that the
> whitespace neatening one is taking care of that. That one patch was
> mostly about taking care of the checkpatch "consistent spacing"
> warning.
> Two solutions here:
> (1) I can merge both patches and make a general whitespace neatening
> one, taking care of that too.
> (2) I can clarify the commit messages of each patches to explain the
> aim of each.
> Of course, in (1) too I'd take care of explaining the whole point of
> the commit. What do you think would be the best approach at this
> point?
If both the patches are doing the same change then it will be better to
combine them in one. Just remember two things while sending patches:
1) your commit message should describe the change you are doing and
incase of big changes mention why you are doing it.
2) You should not do more than one type of change in a patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/