Re: [PATCH v3 00/51] PCI: Resource allocation cleanup for v4.3

[Yinghai Lu]

On Mon, Aug 17, 2015 at 3:48 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> Overall comments:
>
> Thanks for paying attention to your subject lines.  They are
> capitalized and punctuated quite consistently.
>
> The one-line subject is a summary.  The body of the changelog is not a
> continuation of it.  The body should stand alone even if you don't
> read the subject.  Sometimes that means you have to repeat the subject
> line in the body.  That's OK.
>
> Please use "()" when referring to functions.  You do it sometimes, but
> not always.

Thanks for checking them. Will update those changelog.

>
> I think we should talk about "required/optional" resources instead of
> "must/optional" ones.  Is "addon" a third, separate, thing?

yes, addon should be same as optional.

Actually for devices resources, could safely use required/optional resources.
those resources either required only or optional only resources.
for bridge resources, that is little confusing, as those resources could
have required part only or optional part only or have required part +
optional part.

will update changelog to make them consistent.

also will check code/comment...

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/