Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

[Ingo Molnar]

* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Sat, Aug 15, 2015 at 12:23:54AM -0700, Andrew Morton wrote:
> > On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > 
> > > This adds a CONFIG_STACK_VALIDATION option which enables a host tool
> > > named stackvalidate which runs at compile time.
> > 
> > It would be useful to
> > 
> > - show example output for a typical error site
> > 
> > - describe the consequences of that error (ie: why should we fix
> >   these things?)
> > 
> > - describe what needs to be done to repair these sites.
> > 
> > 
> > IOW, what do we gain from merging all this stuff?
> 
> I attempted to do all that in Documentation/stack-validation.txt which
> is in patch 03/20.  Does it address your concerns?  Here it is:

I think it answers the first and third question, but not the second one:

    - describe the consequences of that error (ie: why should we fix
      these things?)

would be nice to document all that richly.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/