Re: [PATCHv7 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings

[Christian Gromm]

On Fri, 14 Aug 2015 12:18:04 +0200
Adrian Remonda <adrianremonda@xxxxxxxxx> wrote:

> This is a patch to the most/aim_cdev.c file. It makes several
> local functions and structures static to prevent global visibility.
> 
> Signed-off-by: Adrian Remonda <adrianremonda@xxxxxxxxx>
Acked-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> ---
>  drivers/staging/most/aim-cdev/cdev.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
> index 252a17cf153c..0a13d8d0fa39 100644
> --- a/drivers/staging/most/aim-cdev/cdev.c
> +++ b/drivers/staging/most/aim-cdev/cdev.c
> @@ -49,7 +49,7 @@ static struct list_head channel_list;
>  static spinlock_t ch_list_lock;
>  
>  
> -struct aim_channel *get_channel(struct most_interface *iface, int id)
> +static struct aim_channel *get_channel(struct most_interface *iface, int id)
>  {
>  	struct aim_channel *channel, *tmp;
>  	unsigned long flags;
> @@ -289,7 +289,7 @@ static const struct file_operations channel_fops = {
>   * This frees allocated memory and removes the cdev that represents this
>   * channel in user space.
>   */
> -int aim_disconnect_channel(struct most_interface *iface, int channel_id)
> +static int aim_disconnect_channel(struct most_interface *iface, int channel_id)
>  {
>  	struct aim_channel *channel;
>  	unsigned long flags;
> @@ -329,7 +329,7 @@ int aim_disconnect_channel(struct most_interface *iface, int channel_id)
>   * This searches for the channel linked to this MBO and stores it in the local
>   * fifo buffer.
>   */
> -int aim_rx_completion(struct mbo *mbo)
> +static int aim_rx_completion(struct mbo *mbo)
>  {
>  	struct aim_channel *channel;
>  
> @@ -356,7 +356,7 @@ int aim_rx_completion(struct mbo *mbo)
>   *
>   * This wakes sleeping processes in the wait-queue.
>   */
> -int aim_tx_completion(struct most_interface *iface, int channel_id)
> +static int aim_tx_completion(struct most_interface *iface, int channel_id)
>  {
>  	struct aim_channel *channel;
>  
> @@ -376,7 +376,7 @@ int aim_tx_completion(struct most_interface *iface, int channel_id)
>  	return 0;
>  }
>  
> -struct most_aim cdev_aim;
> +static struct most_aim cdev_aim;
>  
>  /**
>   * aim_probe - probe function of the driver module
> @@ -390,9 +390,9 @@ struct most_aim cdev_aim;
>   *
>   * Returns 0 on success or error code otherwise.
>   */
> -int aim_probe(struct most_interface *iface, int channel_id,
> -	      struct most_channel_config *cfg,
> -	      struct kobject *parent, char *name)
> +static int aim_probe(struct most_interface *iface, int channel_id,
> +		     struct most_channel_config *cfg,
> +		     struct kobject *parent, char *name)
>  {
>  	struct aim_channel *channel;
>  	unsigned long cl_flags;
> @@ -463,7 +463,7 @@ error_alloc_channel:
>  	return retval;
>  }
>  
> -struct most_aim cdev_aim = {
> +static struct most_aim cdev_aim = {
>  	.name = "cdev",
>  	.probe_channel = aim_probe,
>  	.disconnect_channel = aim_disconnect_channel,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/