[PATCH v2 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY

From: Al Stone
Date: Wed Aug 19 2015 - 18:09:05 EST


Now that we have introduced the bad_madt_entry() function, and that
function is being invoked in acpi_table_parse_madt() for us, there
is no longer any need to use the BAD_MADT_ENTRY macro.

Signed-off-by: Al Stone <al.stone@xxxxxxxxxx>
Cc: Tony Luck <tony.luck@xxxxxxxxx>
Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
---
arch/ia64/kernel/acpi.c | 20 --------------------
1 file changed, 20 deletions(-)

diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
index b1698bc..efa3f0a 100644
--- a/arch/ia64/kernel/acpi.c
+++ b/arch/ia64/kernel/acpi.c
@@ -184,9 +184,6 @@ acpi_parse_lapic_addr_ovr(struct acpi_subtable_header * header,

lapic = (struct acpi_madt_local_apic_override *)header;

- if (BAD_MADT_ENTRY(lapic, end))
- return -EINVAL;
-
if (lapic->address) {
iounmap(ipi_base_addr);
ipi_base_addr = ioremap(lapic->address, 0);
@@ -201,8 +198,6 @@ acpi_parse_lsapic(struct acpi_subtable_header * header, const unsigned long end)

lsapic = (struct acpi_madt_local_sapic *)header;

- /*Skip BAD_MADT_ENTRY check, as lsapic size could vary */
-
if (lsapic->lapic_flags & ACPI_MADT_ENABLED) {
#ifdef CONFIG_SMP
smp_boot_data.cpu_phys_id[available_cpus] =
@@ -222,9 +217,6 @@ acpi_parse_lapic_nmi(struct acpi_subtable_header * header, const unsigned long e

lacpi_nmi = (struct acpi_madt_local_apic_nmi *)header;

- if (BAD_MADT_ENTRY(lacpi_nmi, end))
- return -EINVAL;
-
/* TBD: Support lapic_nmi entries */
return 0;
}
@@ -236,9 +228,6 @@ acpi_parse_iosapic(struct acpi_subtable_header * header, const unsigned long end

iosapic = (struct acpi_madt_io_sapic *)header;

- if (BAD_MADT_ENTRY(iosapic, end))
- return -EINVAL;
-
return iosapic_init(iosapic->address, iosapic->global_irq_base);
}

@@ -253,9 +242,6 @@ acpi_parse_plat_int_src(struct acpi_subtable_header * header,

plintsrc = (struct acpi_madt_interrupt_source *)header;

- if (BAD_MADT_ENTRY(plintsrc, end))
- return -EINVAL;
-
/*
* Get vector assignment for this interrupt, set attributes,
* and program the IOSAPIC routing table.
@@ -336,9 +322,6 @@ acpi_parse_int_src_ovr(struct acpi_subtable_header * header,

p = (struct acpi_madt_interrupt_override *)header;

- if (BAD_MADT_ENTRY(p, end))
- return -EINVAL;
-
iosapic_override_isa_irq(p->source_irq, p->global_irq,
((p->inti_flags & ACPI_MADT_POLARITY_MASK) ==
ACPI_MADT_POLARITY_ACTIVE_LOW) ?
@@ -356,9 +339,6 @@ acpi_parse_nmi_src(struct acpi_subtable_header * header, const unsigned long end

nmi_src = (struct acpi_madt_nmi_source *)header;

- if (BAD_MADT_ENTRY(nmi_src, end))
- return -EINVAL;
-
/* TBD: Support nimsrc entries */
return 0;
}
--
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/