Re: [RFC] fbdev/nvidia:change reverse_order() macro

From: Tomi Valkeinen
Date: Thu Aug 20 2015 - 07:04:20 EST



On 20/08/15 09:52, yalin wang wrote:
> This change reverse_order() to swab32(bitrev32()), so that
> it can have better performance on some platforms.
>
> Signed-off-by: yalin wang <yalin.wang2010@xxxxxxxxx>
> ---
> drivers/video/fbdev/nvidia/nv_accel.c | 4 ++--
> drivers/video/fbdev/nvidia/nv_local.h | 13 ++++---------
> 2 files changed, 6 insertions(+), 11 deletions(-)

I have more or less the same comments here as for the riva patch, except
in this one I'd change the macro to an static inline function.

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature