Re: pstore: pmsg: return -ENOMEM on vmalloc failure

From: Kees Cook
Date: Thu Aug 20 2015 - 17:39:42 EST


On Thu, Aug 20, 2015 at 2:21 PM, Mark Salyzyn <salyzyn@xxxxxxxxxxx> wrote:
> Signed-off-by: Mark Salyzyn <salyzyn@xxxxxxxxxxx>

Eek, yes please.

Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks!

-Kees

> ---
> fs/pstore/pmsg.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/pstore/pmsg.c b/fs/pstore/pmsg.c
> index feb5dd2..5a2f05a 100644
> --- a/fs/pstore/pmsg.c
> +++ b/fs/pstore/pmsg.c
> @@ -37,6 +37,8 @@ static ssize_t write_pmsg(struct file *file, const char __user *buf,
> if (buffer_size > PMSG_MAX_BOUNCE_BUFFER_SIZE)
> buffer_size = PMSG_MAX_BOUNCE_BUFFER_SIZE;
> buffer = vmalloc(buffer_size);
> + if (!buffer)
> + return -ENOMEM;
>
> mutex_lock(&pmsg_lock);
> for (i = 0; i < count; ) {
> --
> 2.5.0.276.gf5e568e
>



--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/