Re: [PATCHv3 0/5] Fix compound_head() race

From: Andrew Morton
Date: Thu Aug 20 2015 - 19:38:42 EST


On Thu, 20 Aug 2015 15:31:07 +0300 "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> wrote:

> On Wed, Aug 19, 2015 at 12:21:41PM +0300, Kirill A. Shutemov wrote:
> > Here's my attempt on fixing recently discovered race in compound_head().
> > It should make compound_head() reliable in all contexts.
> >
> > The patchset is against Linus' tree. Let me know if it need to be rebased
> > onto different baseline.
> >
> > It's expected to have conflicts with my page-flags patchset and probably
> > should be applied before it.
> >
> > v3:
> > - Fix build without hugetlb;
> > - Drop page->first_page;
> > - Update comment for free_compound_page();
> > - Use 'unsigned int' for page order;
> >
> > v2: Per Hugh's suggestion page->compound_head is moved into third double
> > word. This way we can avoid memory overhead which v1 had in some
> > cases.
> >
> > This place in struct page is rather overloaded. More testing is
> > required to make sure we don't collide with anyone.
>
> Andrew, can we have the patchset applied, if nobody has objections?

I've been hoping to hear from Hugh and I wasn't planning on processing
these before the 4.2 release.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/