Re: [RFC] fbdev/riva:change to use generice function to implement reverse_order()

From: Tomi Valkeinen
Date: Fri Aug 21 2015 - 02:41:33 EST




On 20/08/15 14:30, yalin wang wrote:
>
>> On Aug 20, 2015, at 19:02, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote:
>>
>>
>> On 10/08/15 13:12, yalin wang wrote:
>>> This change to use swab32(bitrev32()) to implement reverse_order()
>>> function, have better performance on some platforms.
>>
>> Which platforms? Presuming you tested this, roughly how much better
>> performance? If you didn't, how do you know it's faster?
>
> i investigate on arm64 platforms:

Ok. So is any arm64 platform actually using these devices? If these
devices are mostly used by 32bit x86 platforms, optimizing them for
arm64 doesn't make any sense.

Possibly the patches are still good for x86 also, but that needs to be
proven.

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature