Re: [PATCH/RFC v6 05/36] leds: Improve setting brightness in a non sleeping way
From: Jacek Anaszewski
Date: Fri Aug 21 2015 - 05:22:48 EST
Hi Andrew,
Thanks for the review.
On 08/20/2015 06:09 PM, Andrew Lunn wrote:
On Thu, Aug 20, 2015 at 04:43:35PM +0200, Jacek Anaszewski wrote:
This patch replaces led_set_brightness_async with
led_set_brightness_nosleep in all places where the most vital was setting
brightness in a non sleeping way but not necessarily asynchronously, which
is not needed for non-blocking drivers.
O.K, so i've lost the plot. _sync, _asymc, _nosleep, etc. Too many
changes without a clearly documented vision of what you are trying to
achieve.
How about splitting this up into at least two patch sets.
1) Add the brightness_set_blocking op and the minimum of changes
needed to the core to make it work, and the driver changes taking out
the work queue.
The minimum of changes needed includes harnessing existing
set_brightness_work for setting brightness instead of the work queues
in the drivers. First three patches in the patch set are indispensable
to implement this and avoid breakage of blinking feature. Especially
patch 3/36 is quite complex, but I didn't have better idea on how to
tackle this problem without breaking bisect,
2) A set of patches cleaning up the core and its API. We want a well
documented linux/leds.h and drivers/led/leds.h defining the APIs which
users and triggers should be using.
Of course, I will document led_set_brightness_async and
led_set_brightness_nosleep functions.
--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/