Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device

[ygardi]

> 2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>:
>> @@ -1036,7 +1037,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba
>> *hba)
>>   * The variant operations configure the necessary controller and PHY
>>   * handshake during initialization.
>>   */
>> -static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
>> +static struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
>
> It's better to keep const.  In order to do this, we also need to put
> const to 'vops' member in struct ufs_hba and the second argument of
> ufshcd_pltfrm_init().

Why do you think it would be better to keep the vops as a const and have
the vops member in struct ufs_hba be const ?
I would say it is better to have the vops as is, and let each variany
decidehow it should behave.


>
>> +static void ufs_qcom_shutdown(struct platform_device *pdev)
>> +{
>> +       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));
>> +}
>
> We don't need this function anymore since we have
> ufshcd_pltfrm_shutdown() now.

ok, as this variant shutdown is doing the same as pltform shutdown' it can
go away.

>
>> -static void ufshcd_pltfrm_shutdown(struct platform_device *pdev)
>> +void ufshcd_pltfrm_shutdown(struct platform_device *pdev)
>>  {
>> -       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));
>> +       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));
>
> Whitespace is used as code indent.  There are same issues in
> this patch series, so I recommend running checkpatch.pl before
> sending patches.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/