Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

[Akinobu Mita]

2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>:

> +static bool ufs_qcom_testbus_cfg_is_ok(struct ufs_qcom_host *host)
> +{
> +       if (host->testbus.select_major >= TSTBUS_MAX) {
> +               dev_err(host->hba->dev,
> +                       "%s: UFS_CFG1[TEST_BUS_SEL} may not equal 0x%05X\n",
> +                       __func__, host->testbus.select_major);
> +               return false;
> +       }
> +
> +       /*
> +        * Not performing check for each individual select_major
> +        * mappings of select_minor, since there is no harm in
> +        * configuring a non-existent select_minor
> +        */
> +       if (host->testbus.select_major > 0x1F) {

select_minor should be checked instead of select_major here?

> +               dev_err(host->hba->dev,
> +                       "%s: 0x%05X is not a legal testbus option\n",
> +                       __func__, host->testbus.select_minor);
> +               return false;
> +       }
> +
> +       return true;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/